Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new admin action that allows to create external certificates #85

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

andrey-canon
Copy link
Collaborator

Description

Adds a new admin action class that allows to create external certificates, this logic came from the model implementation https://github.com/openedx/edx-platform/blob/master/lms/djangoapps/certificates/models.py#L524 and the previous implemented celery task https://github.com/eduNEXT/eox-nelp/blob/master/eox_nelp/signals/tasks.py#L140

Issue:
https://edunext.atlassian.net/browse/FUTUREX-486

Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is working the only thing is a little typo of docstring but nothing critical.
Peek 2023-08-14 15-11

"""Certificates admin file.
Contains all the nelp admin models for certificates.

classes:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
classes:
Classes:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@andrey-canon andrey-canon merged commit 4da49e2 into master Aug 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants